Add security policy for general endpoints#2100
Merged
MarceloRGonc merged 4 commits intomainfrom Mar 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces project-scoped route security policies to several existing API endpoints, aiming to standardize how authorization intent (principal types + permissions) is expressed per route.
Changes:
- Add
getProjectScopedRoutePolicy(...)configuration to selected endpoints (user settings, trigger events, folders, form retrieval, flow-version test output). - Update folder endpoints to use folder-specific permissions (
READ_FOLDER/WRITE_FOLDER) in the new policy configuration. - Add explicit request options object for the “Get user settings” route to align with the existing “Upsert user settings” configuration pattern.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/server/api/src/app/user-settings/user-settings.module.ts | Adds route options + project-scoped security policy for GET user settings; adds policy to upsert route config. |
| packages/server/api/src/app/flows/trigger-events/trigger-event.module.ts | Adds project-scoped route policy (principal + flow permissions) to trigger-events routes. |
| packages/server/api/src/app/flows/folder/folder.module.ts | Adds project-scoped route policy to folder routes and switches to folder-specific permissions. |
| packages/server/api/src/app/flows/flow/form/form.controller.ts | Adds project-scoped route policy requiring READ_FLOW to form retrieval endpoint. |
| packages/server/api/src/app/flows/flow/flow-version.controller.ts | Adds project-scoped route policy requiring TEST_STEP_FLOW to test-output endpoints. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/server/api/src/app/flows/trigger-events/trigger-event.module.ts
Show resolved
Hide resolved
packages/server/api/src/app/flows/trigger-events/trigger-event.module.ts
Show resolved
Hide resolved
packages/server/api/src/app/flows/trigger-events/trigger-event.module.ts
Show resolved
Hide resolved
|
bigfluffycookie
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes OPS-3886.