Skip to content

Add security policy for general endpoints#2100

Merged
MarceloRGonc merged 4 commits intomainfrom
mg/add-security
Mar 10, 2026
Merged

Add security policy for general endpoints#2100
MarceloRGonc merged 4 commits intomainfrom
mg/add-security

Conversation

@MarceloRGonc
Copy link
Contributor

@MarceloRGonc MarceloRGonc commented Mar 10, 2026

Fixes OPS-3886.

Copilot AI review requested due to automatic review settings March 10, 2026 16:54
@linear
Copy link

linear bot commented Mar 10, 2026

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces project-scoped route security policies to several existing API endpoints, aiming to standardize how authorization intent (principal types + permissions) is expressed per route.

Changes:

  • Add getProjectScopedRoutePolicy(...) configuration to selected endpoints (user settings, trigger events, folders, form retrieval, flow-version test output).
  • Update folder endpoints to use folder-specific permissions (READ_FOLDER / WRITE_FOLDER) in the new policy configuration.
  • Add explicit request options object for the “Get user settings” route to align with the existing “Upsert user settings” configuration pattern.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/server/api/src/app/user-settings/user-settings.module.ts Adds route options + project-scoped security policy for GET user settings; adds policy to upsert route config.
packages/server/api/src/app/flows/trigger-events/trigger-event.module.ts Adds project-scoped route policy (principal + flow permissions) to trigger-events routes.
packages/server/api/src/app/flows/folder/folder.module.ts Adds project-scoped route policy to folder routes and switches to folder-specific permissions.
packages/server/api/src/app/flows/flow/form/form.controller.ts Adds project-scoped route policy requiring READ_FLOW to form retrieval endpoint.
packages/server/api/src/app/flows/flow/flow-version.controller.ts Adds project-scoped route policy requiring TEST_STEP_FLOW to test-output endpoints.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

@MarceloRGonc MarceloRGonc merged commit 9b4caf0 into main Mar 10, 2026
21 checks passed
@MarceloRGonc MarceloRGonc deleted the mg/add-security branch March 10, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants