Fix crash when destroying a gangzone while UseGangZoneCheck is active#1240
Open
krzysztofmotas wants to merge 1 commit into
Open
Fix crash when destroying a gangzone while UseGangZoneCheck is active#1240krzysztofmotas wants to merge 1 commit into
krzysztofmotas wants to merge 1 commit into
Conversation
Avoid iterator invalidation by taking a snapshot of checkingList IDs before iterating. Replace direct IGangZone* iteration with a DynamicArray<int> of IDs, store entered zones as IDs, and re-validate get(id)/checkingList.valid(id)/isShownForPlayer before use. Apply same snapshot approach in onPlayerClickMap. This prevents crashes when a gangzone is destroyed during dispatch.
krzysztofmotas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destroying a gangzone from within its enter/leave/click callback while checking was enabled crashed the server, because it removed the zone from the internal list mid-iteration. The update/click loops now snapshot zone IDs upfront and re-validate each one before dispatching its event, so a destroy mid-callback no longer corrupts the iteration.