Repository navigation
Install greenlet via the sqlalchemy[asyncio] extra - #380
anshuly0720 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. WalkthroughThe project now declares Change: Bug fix · Severity of issue fixed: Medium Merge Risk:
|
|
@anshuly0720 Removing greenlet reproduces the original error. The non-PHP, non-slow tests gave 299 passed, 1 xfailed and 4 dataset-filtering failures; those same four also fail with the base source using the same dependencies. |
|
Thanks @Jayant-kernel for testing! Interesting about the 4 dataset-filtering failures: they all passed for me (303 passed, 1 xfailed), so they may depend on the local environment. Since they also fail on |
Description
Fixes: #377
src/database/engine.pyusessqlalchemy.ext.asyncio, which requiresgreenlet. Since SQLAlchemy 2.1,greenletis only installed with theasyncioextra, so fresh builds currently install SQLAlchemy 2.1.x without it and thepython-apicontainer exits on startup.This changes the dependency in
pyproject.tomlfromsqlalchemytosqlalchemy[asyncio]. No code changes.Verified locally: after rebuilding the image (
docker compose up -d --build python-api), the container starts,/docsloads, andpytest -m "not php_api and not slow"passes (303 passed, 1 xfailed). With the PHP API running,tests/routers/task_type_get_test.pyalso passes (12 passed).Checklist
Always:
Required for code changes:
If applicable:
/docs) (N/A)Extra context: