[MNT] add pytest marker to tests requiring test server #1599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
great! Can we now skip them, to temporarily disable the failures? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1599 +/- ##
=======================================
Coverage 52.72% 52.72%
=======================================
Files 36 36
Lines 4326 4326
=======================================
Hits 2281 2281
Misses 2045 2045 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fkiraly
added
testing
maintenance & CI
fkiraly
approved these changes
Jan 7, 2026
Collaborator
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
Hopefully, this fixes the failing tests now - temporarily at least.
JATAYU000
pushed a commit
to JATAYU000/openml-python
that referenced
this pull request
Jan 8, 2026
Fixes openml#1598 This PR adds the `@pytest.mark.uses_test_server()` marker to tests that depend on the OpenML test server. Changes * added `uses_test_server` on the relevant test sets. * replaced all the `server` markers with `uses_test_server` marker * removed all the `@pytest.mark.xfail(reason="failures_issue_1544", strict=False)` where the failure was due to race-conditions or server connectivity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1598
This PR adds the
@pytest.mark.uses_test_server()marker to tests that depend on the OpenML test server.Changes
uses_test_serveron the relevant test sets.servermarkers withuses_test_servermarker@pytest.mark.xfail(reason="failures_issue_1544", strict=False)where the failure was due to race-conditions or server connectivity