Skip to content

Store slice overlap indices in cell ID field#4002

Open
paulromano wants to merge 2 commits into
openmc-dev:developfrom
paulromano:overlap-update
Open

Store slice overlap indices in cell ID field#4002
paulromano wants to merge 2 commits into
openmc-dev:developfrom
paulromano:overlap-update

Conversation

@paulromano

Copy link
Copy Markdown
Contributor

Description

This updates slice plot overlap handling so the encoded overlap index is stored in the cell ID field rather than the material ID field. The Python overlap helper function also now returns a shaped (n, 3) array of overlap metadata and includes docstrings/type annotations.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 18) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@pshriwise pshriwise left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me @paulromano. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants