Skip to content

Conversation

@GuySten
Copy link
Contributor

@GuySten GuySten commented Jan 28, 2026

Description

Because OpenMC does not transport charged particles and other than heating there are no scores that use charged particles bins,
users might forget to tally positron and electron bins when calculating heating score and using particle filter.
This PR add a warning for that case.

Examples where user forgot to tally heating charged particles bins:
https://openmc.discourse.group/t/photon-heating-discrepancies-with-mcnp-and-open-mc/5705
https://openmc.discourse.group/t/benchmark-against-mcnp-and-tripoli4-unsatisfactory/3154

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@shimwell
Copy link
Member

Great idea. Keen to see this merged. Wondering if the warning can be more specific about what the user needs to do to fix. perhaps it could go as far as giving the python code snippet of what is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants