Skip to content

Conversation

@GuySten
Copy link
Contributor

@GuySten GuySten commented Jan 26, 2026

Description

Currently the global neutron russian roulette (which is used when survival biasing is turned on) conflicts with the application of weight windows.
As suggested in #2773 (comment), this PR makes global neutron russian roulette apply only when neutrons are outside of the weight windows mesh boundaries.

Fixes #2773

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@GuySten GuySten requested a review from nelsonag as a code owner January 26, 2026 22:04
@GuySten GuySten added the Bugs label Jan 26, 2026
@GuySten GuySten changed the title Resolve conflicts with weight windows and global russian roulette Resolve conflict with weight windows and global russian roulette Jan 26, 2026
@GuySten GuySten marked this pull request as draft January 27, 2026 07:45
@GuySten GuySten marked this pull request as ready for review January 27, 2026 08:30
Copy link
Contributor

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GuySten! You are a machine. Some thoughts to consider here in the comments.

@GuySten GuySten requested a review from pshriwise January 27, 2026 23:32
@GuySten
Copy link
Contributor Author

GuySten commented Jan 27, 2026

I've restructured the code to be more backwards compatible.

@GuySten
Copy link
Contributor Author

GuySten commented Jan 28, 2026

I've further improved the code structure according to your suggestion.
I will have to dig into why the tests fail.

@GuySten GuySten requested a review from pshriwise January 29, 2026 00:03
@GuySten
Copy link
Contributor Author

GuySten commented Jan 29, 2026

This PR is now ready for another review iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weight windows while using survival biasing

2 participants