Allowing model.id_map to return overlap ID values #3669
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR adds the option to use the
color_overlapsargument when calling theid_mapfunction. It looks like this argument is well supported upto the openmc.lib layer and then not in the final user facingid_mapfunction. It would be useful for me to find overlaps using this function.I also added a simple test to check -3 (which is the overlap ID number) appears in the returned numpy array only when the flag is used. I set the default to fault to preserve current behaviour
Fixes # (issue)
Checklist