-
Notifications
You must be signed in to change notification settings - Fork 232
8311588: C2: RepeatCompilation compiler directive does not choose stress seed randomly #4172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into |
|
@elifaslan1 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request Clean backport to make JDK-8319879 backporting cleaner. The compiler directive RepeatCompilation can be used to repeat compilations of specific methods, for example for Test::test(): -XX:CompileCommand=RepeatCompilation,Test::test,1000 When using this compiler directive in combination with StressIGVN/CCP/GCM/LCM, C2 only sets the stress seed once to a random value. Afterward, it keeps the seed for all repeated compilations. This should be changed to always select a random seed with each repetition (i.e. get the same behavior as the flag RepeatCompilation). |
|
@elifaslan1 |
|
/integrate |
|
@elifaslan1 |
Clean backport to make JDK-8319879 backporting cleaner. The compiler directive RepeatCompilation can be used to repeat compilations of specific methods, for example for Test::test():
-XX:CompileCommand=RepeatCompilation,Test::test,1000
When using this compiler directive in combination with StressIGVN/CCP/GCM/LCM, C2 only sets the stress seed once to a random value. Afterward, it keeps the seed for all repeated compilations. This should be changed to always select a random seed with each repetition (i.e. get the same behavior as the flag RepeatCompilation).
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4172/head:pull/4172$ git checkout pull/4172Update a local copy of the PR:
$ git checkout pull/4172$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4172/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4172View PR using the GUI difftool:
$ git pr show -t 4172Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4172.diff
Using Webrev
Link to Webrev Comment