Skip to content

Conversation

@elifaslan1
Copy link
Contributor

@elifaslan1 elifaslan1 commented Nov 12, 2025

Clean backport to make JDK-8319879 backporting cleaner. The compiler directive RepeatCompilation can be used to repeat compilations of specific methods, for example for Test::test():

-XX:CompileCommand=RepeatCompilation,Test::test,1000

When using this compiler directive in combination with StressIGVN/CCP/GCM/LCM, C2 only sets the stress seed once to a random value. Afterward, it keeps the seed for all repeated compilations. This should be changed to always select a random seed with each repetition (i.e. get the same behavior as the flag RepeatCompilation).


Progress

  • Change must not contain extraneous whitespace
  • JDK-8311588 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8311588: C2: RepeatCompilation compiler directive does not choose stress seed randomly (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4172/head:pull/4172
$ git checkout pull/4172

Update a local copy of the PR:
$ git checkout pull/4172
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4172/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4172

View PR using the GUI difftool:
$ git pr show -t 4172

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4172.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2025

👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@elifaslan1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311588: C2: RepeatCompilation compiler directive does not choose stress seed randomly

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 6d2e15c: 8294314: Minimize disabled warnings in hotspot
  • 8b2e9f5: 8327757: Convert javax/swing/JSlider/6524424/bug6524424.java applet to main
  • 7a889a5: 8327856: Convert applet test SpanishDiacriticsTest.java to a main program

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 3465179458d844fec4d0496aa3d0c31b34c4c345 8311588: C2: RepeatCompilation compiler directive does not choose stress seed randomly Nov 12, 2025
@openjdk
Copy link

openjdk bot commented Nov 12, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 12, 2025
@openjdk
Copy link

openjdk bot commented Nov 12, 2025

⚠️ @elifaslan1 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 12, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2025

Webrevs

@elifaslan1
Copy link
Contributor Author

/approval request Clean backport to make JDK-8319879 backporting cleaner. The compiler directive RepeatCompilation can be used to repeat compilations of specific methods, for example for Test::test():

-XX:CompileCommand=RepeatCompilation,Test::test,1000

When using this compiler directive in combination with StressIGVN/CCP/GCM/LCM, C2 only sets the stress seed once to a random value. Afterward, it keeps the seed for all repeated compilations. This should be changed to always select a random seed with each repetition (i.e. get the same behavior as the flag RepeatCompilation).

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@elifaslan1
8311588: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 12, 2025
@elifaslan1
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 12, 2025
@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@elifaslan1
Your change (at version 447542c) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored

Development

Successfully merging this pull request may close these issues.

1 participant