Skip to content

Conversation

@mmm-choi
Copy link

@mmm-choi mmm-choi commented Nov 11, 2025

Backporting JDK-8324861. Had to resolve manually because openjdk/jdk@6bd2794 doesn't exist for 17.

But it is a very simple fix.
Low risk, simple change of logging code.

Impact: Prevents memory leaks in diagnostic/debug scenarios


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8324861 needs maintainer approval

Issue

  • JDK-8324861: Exceptions::wrap_dynamic_exception() doesn't have ResourceMark (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4170/head:pull/4170
$ git checkout pull/4170

Update a local copy of the PR:
$ git checkout pull/4170
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4170/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4170

View PR using the GUI difftool:
$ git pr show -t 4170

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4170.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2025

👋 Welcome back mmm-choi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

@mmm-choi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324861: Exceptions::wrap_dynamic_exception() doesn't have ResourceMark

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 7d1a48807a482cd19156298ce21d9492f0d912da 8324861: Exceptions::wrap_dynamic_exception() doesn't have ResourceMark Nov 11, 2025
@openjdk
Copy link

openjdk bot commented Nov 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 11, 2025
@mmm-choi mmm-choi marked this pull request as ready for review November 11, 2025 22:10
@openjdk
Copy link

openjdk bot commented Nov 11, 2025

⚠️ @mmm-choi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 11, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 11, 2025

Webrevs

@mmm-choi
Copy link
Author

mmm-choi commented Nov 11, 2025

/approval request It is a very simple fix. Low risk, simple change of logging code.

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

@mmm-choi usage: /approval [<id>] (request|cancel) [<text>]

@mmm-choi
Copy link
Author

/approval request It is a very simple fix. Low risk, simple change of logging code.

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

@mmm-choi
8324861: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 11, 2025
@mmm-choi
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 12, 2025
@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@mmm-choi
Your change (at version 8a03bee) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored

Development

Successfully merging this pull request may close these issues.

1 participant