Skip to content

Conversation

@anton-seoane
Copy link
Contributor

@anton-seoane anton-seoane commented Nov 10, 2025


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ The pull request body must not be empty.

Issue

  • JDK-8343382: Generalize dump methods to accept outputStream arguments (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28220/head:pull/28220
$ git checkout pull/28220

Update a local copy of the PR:
$ git checkout pull/28220
$ git pull https://git.openjdk.org/jdk.git pull/28220/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28220

View PR using the GUI difftool:
$ git pr show -t 28220

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28220.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2025

👋 Welcome back aseoane! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 10, 2025

⚠️ @anton-seoane This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 10, 2025
@openjdk
Copy link

openjdk bot commented Nov 10, 2025

@anton-seoane The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant