-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8371573: Shenandoah: Remove unnecessary include after JDK-8351091 #28219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into |
|
@kdnilsen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
earthling-amzn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This include looks vestigial. Can we just delete it?
Good catch. I'll make that change. |
shipilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, but I adjusted the bug title, so PR title also needs adjustments to match it.
|
I also think it is trivial, so you can integrate as soon as testing is green. |
|
/integrate |
|
Going to push as commit 43afce5.
Your commit was automatically rebased without conflicts. |
Fix style of include directive for improved consistency and compatibility with GraalVM conventions.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28219/head:pull/28219$ git checkout pull/28219Update a local copy of the PR:
$ git checkout pull/28219$ git pull https://git.openjdk.org/jdk.git pull/28219/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28219View PR using the GUI difftool:
$ git pr show -t 28219Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28219.diff
Using Webrev
Link to Webrev Comment