Skip to content

Conversation

@kdnilsen
Copy link
Contributor

@kdnilsen kdnilsen commented Nov 10, 2025

Fix style of include directive for improved consistency and compatibility with GraalVM conventions.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371573: Shenandoah: Remove unnecessary include after JDK-8351091 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28219/head:pull/28219
$ git checkout pull/28219

Update a local copy of the PR:
$ git checkout pull/28219
$ git pull https://git.openjdk.org/jdk.git pull/28219/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28219

View PR using the GUI difftool:
$ git pr show -t 28219

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28219.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2025

👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 10, 2025

@kdnilsen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371573: Shenandoah: Remove unnecessary include after JDK-8351091

Reviewed-by: wkemper, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Nov 10, 2025
@openjdk
Copy link

openjdk bot commented Nov 10, 2025

@kdnilsen The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 10, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 10, 2025

Webrevs

Copy link
Contributor

@earthling-amzn earthling-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This include looks vestigial. Can we just delete it?

@kdnilsen
Copy link
Contributor Author

This include looks vestigial. Can we just delete it?

Good catch. I'll make that change.

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but I adjusted the bug title, so PR title also needs adjustments to match it.

@shipilev
Copy link
Member

I also think it is trivial, so you can integrate as soon as testing is green.

@kdnilsen kdnilsen changed the title 8371573: Shenandoah: Fix style of include directive 8371573: Shenandoah: Remove unnecessary include after JDK-8351091 Nov 10, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 10, 2025
@kdnilsen
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 10, 2025

Going to push as commit 43afce5.
Since your change was applied there have been 5 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 10, 2025
@openjdk openjdk bot closed this Nov 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 10, 2025
@openjdk
Copy link

openjdk bot commented Nov 10, 2025

@kdnilsen Pushed as commit 43afce5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants