Skip to content

Conversation

@eme64
Copy link
Contributor

@eme64 eme64 commented Nov 10, 2025

JDK-8371523 Found multiple fuzzer failures Identity optimizations in:

ConvD2L
ConvF2I
ConvF2L
ConvI2F

Example:

< Missed Identity optimization:
< Old node:
< dist dump
< ---------------------------------------------
< 1 2315 ConvL2D === _ 2120 [[ 2306 2314 2318 ]] #double !orig=845,[2608],[2215] !jvms: Test_2167::vMeth @ bci:128 (line 56)
< 0 2314 ConvD2L === _ 2315 [[ 2313 1052 845 ]] #long !orig=1074 !jvms: Test_2167::vMeth @ bci:204 (line 65)
< New node:
< dist dump
< ---------------------------------------------
< 1 2121 ConvL2D === _ 2123 [[ 2112 2120 2124 ]] #double !orig=845,[2608],[2215] !jvms: Test_2167::vMeth @ bci:128 (line 56)
< 0 2120 ConvD2L === _ 2121 [[ 2119 2315 2316 2667 ]] #long !orig=1074 !jvms: Test_2167::vMeth @ bci:204 (line 65)

We want to quickly silence the issue, and so we just disable verification here.
There is already a patch out as a fix for at least some of the related issues, though it is not clear to me that it covers cases like ConvF2L: #27900

We can fix the issues and attach reproducers in a follow-up fix.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371528: C2: disable VerifyIterativeGVN Identity verification for ConvF2L etc (Sub-task - P4) ⚠️ Issue is not open.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28212/head:pull/28212
$ git checkout pull/28212

Update a local copy of the PR:
$ git checkout pull/28212
$ git pull https://git.openjdk.org/jdk.git pull/28212/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28212

View PR using the GUI difftool:
$ git pr show -t 28212

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28212.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2025

👋 Welcome back epeter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8371528 8371528: C2: disable VerifyIterativeGVN Identity verification for ConvF2L etc Nov 10, 2025
@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 10, 2025
@openjdk
Copy link

openjdk bot commented Nov 10, 2025

@eme64 The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.


// Fuzzer failures reported in JDK-8371523, and possible variants,
// related to JDK-8369646.
// All of them have a coment like this:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/coment/comment/

@eme64
Copy link
Contributor Author

eme64 commented Nov 11, 2025

This is no longer necessary.

/close

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

@eme64 Unknown command close - for a list of valid commands use /help.

@eme64 eme64 closed this Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants