8371528: C2: disable VerifyIterativeGVN Identity verification for ConvF2L etc #28212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK-8371523 Found multiple fuzzer failures Identity optimizations in:
Example:
We want to quickly silence the issue, and so we just disable verification here.
There is already a patch out as a fix for at least some of the related issues, though it is not clear to me that it covers cases like
ConvF2L: #27900We can fix the issues and attach reproducers in a follow-up fix.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28212/head:pull/28212$ git checkout pull/28212Update a local copy of the PR:
$ git checkout pull/28212$ git pull https://git.openjdk.org/jdk.git pull/28212/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28212View PR using the GUI difftool:
$ git pr show -t 28212Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28212.diff