Repository navigation
Conversation
w-goog
force-pushed
the
codegen/ocmock-appauth-2-platform-instance-api
branch
from
November 11, 2026 21:29
45bac9f to
ac90ee5
Compare
w-goog
force-pushed
the
codegen/ocmock-appauth-2-platform-instance-api
branch
2 times, most recently
from
November 13, 2026 00:05
8d3ef81 to
9f4fb13
Compare
w-goog
force-pushed
the
codegen/ocmock-appauth-2-platform-instance-api
branch
from
November 13, 2026 01:31
9f4fb13 to
d7af094
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds instance versions for the iOS- & macOS-specific methods,
+presentAuthorizationRequest:presentingViewController:callback:and friends. The external user agents also get read-onlypresentingViewController/presentingWindowgetters, so a test can check where the flow would present from.I moved the iOS user agent setup into two static helpers for brevity, and I had to add
-ObjctoAppAuth-iOSTeststo stop the new tests from hitting an unrecognized selector.Testing: the new tests are iOS only (there are no macOS user agent tests to add to).
Note for reviewers: this is number 2 of 4 small PRs targeting 3.1.0. 3 and 4 add an
AppAuthTestHelpersproduct with the fakes.