Skip to content

Add instance versions of the iOS- & macOS-specific convenience methods - #991

Open
w-goog wants to merge 5 commits into
codegen/ocmock-appauth-1-service-instance-apifrom
codegen/ocmock-appauth-2-platform-instance-api
Open

w-goog wants to merge 5 commits into
codegen/ocmock-appauth-1-service-instance-apifrom
codegen/ocmock-appauth-2-platform-instance-api

Conversation

@w-goog

@w-goog w-goog commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

This PR adds instance versions for the iOS- & macOS-specific methods, +presentAuthorizationRequest:presentingViewController:callback: and friends. The external user agents also get read-only presentingViewController / presentingWindow getters, so a test can check where the flow would present from.

I moved the iOS user agent setup into two static helpers for brevity, and I had to add -Objc to AppAuth-iOSTests to stop the new tests from hitting an unrecognized selector.

Testing: the new tests are iOS only (there are no macOS user agent tests to add to).

Note for reviewers: this is number 2 of 4 small PRs targeting 3.1.0. 3 and 4 add an AppAuthTestHelpers product with the fakes.

@w-goog
w-goog force-pushed the codegen/ocmock-appauth-2-platform-instance-api branch from 45bac9f to ac90ee5 Compare November 11, 2026 21:29
@w-goog
w-goog added this pull request to stack #995 November 11, 2026 21:35
@w-goog w-goog changed the title Add instance versions of the iOS and macOS convenience methods Add instance versions of the iOS- & macOS-specific convenience methods Nov 11, 2026
@w-goog
w-goog requested a review from ch40w31 November 11, 2026 22:13
@w-goog
w-goog force-pushed the codegen/ocmock-appauth-2-platform-instance-api branch 2 times, most recently from 8d3ef81 to 9f4fb13 Compare November 13, 2026 00:05
@w-goog
w-goog force-pushed the codegen/ocmock-appauth-2-platform-instance-api branch from 9f4fb13 to d7af094 Compare November 13, 2026 01:31

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant