Use cross-OS way to delete build output#176
Open
jeroenheijmans wants to merge 1 commit intoopenid:masterfrom
Open
Use cross-OS way to delete build output#176jeroenheijmans wants to merge 1 commit intoopenid:masterfrom
jeroenheijmans wants to merge 1 commit intoopenid:masterfrom
Conversation
|
👋 This approach is creative, but comes at the expense of obscuring the intent behind the code. My 2c: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #175
Saw #175 come by in my feed. Have successfully solved this with the
rimrafnpm package which is one of the suggestions in the top Stack Overflow post on the subject, but I personally agree with the lower voted answer that for such a simple task using a package with less dependencies seems preferable.I've tested this on my Windows 10 machine, not yet on any Linux VM (nor did I see any CI or GitHub actions in this repo to verify it?). Will first see what the maintainers think of this approach.
If you don't like this approach: no harm done! Your call.
(I realize the title of #175 is "Powershell support", but I took it to be in general about cross-OS and cross-shell support. It should also work with
cmd, right?)