Added convert value expiresIn to number.#132
Open
bartdeveloper wants to merge 1 commit intoopenid:masterfrom
bartdeveloper:patch-1
Open
Added convert value expiresIn to number.#132bartdeveloper wants to merge 1 commit intoopenid:masterfrom bartdeveloper:patch-1
bartdeveloper wants to merge 1 commit intoopenid:masterfrom
bartdeveloper:patch-1
Conversation
In Ionic framework (with Angular 8) without convert Number(this.expiresIn) isValid() function often return false (e.g. when expiresIn has value 3600 and buffer has value -600).
Collaborator
|
I think the better approach might be to deal with this when we deserialize the token response. That way we don’t have to do this every time |
Author
|
Sure, this approach will be more efficiently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Ionic framework 4 (with Angular 8 and Azure AD as login provider) without convert Number(this.expiresIn) isValid() function often return false (e.g. when expiresIn has value 3600 and buffer has value -600). It occurs only on mobile device (run on Samsung A40, Android 9.0, Chrome 78) with authorization code flow - then Azure AD return unfortunately expiresIn value as string. While testing in web browser on computer (Windows 10, Chrome 78) then is OK, in this case Azure AD return expiresIn value as number.