add The Straits map

[RickD004]

Description:

Adds "The Straits" map:
A map located around Denmark and the many surrounding straits: Kattegat, Skagerrak and the Danish straits (thus the name, meant to be a creative name like "Between Two Seas" and "Gateway to the Atlantic").

This map is themed in the early 1900s, the nations/NPCs are traditional and historical regions of Sweden-Norway, Denmark and the German Empire.

Relatively small map with 700k land tiles, similar to World

Inspired by this Discord thread with nearly 20 upvotes: https://canary.discord.com/channels/1284581928254701718/1482089104110911634/1482089104110911634

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star1011

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d277fcd4-04c2-4fce-9a72-e9394ac9d3a5

📥 Commits

Reviewing files that changed from the base of the PR and between 57ecaa6 and 541b18b.

📒 Files selected for processing (4)

• map-generator/main.go
• resources/lang/en.json
• src/core/game/Game.ts
• src/server/MapPlaylist.ts

✅ Files skipped from review due to trivial changes (3)

• resources/lang/en.json
• src/core/game/Game.ts
• src/server/MapPlaylist.ts

---

Walkthrough

Adds a new map "The Straits" across assets, manifest, localization, game config, map-generator registry, and server playlist; includes multiple nation/region entries with fixed coordinates, display names, and flag identifiers.

Changes

Cohort / File(s)	Summary
Map Assets & Data map-generator/assets/maps/thestraits/info.json, resources/maps/thestraits/manifest.json	New map metadata and manifest for thestraits defining tile grids and a nations list with fixed 2D coordinates, display names, and flag identifiers.
Game Configuration src/core/game/Game.ts	Adds TheStraits value to GameMapType and includes it in mapCategories under the regional cohort.
Map Generator map-generator/main.go	Registers "thestraits" in the map-generator maps registry so it can be generated (production output path).
Server Playlist src/server/MapPlaylist.ts	Adds TheStraits to playlist weights with frequency 5, so it is included in map selection.
Localization resources/lang/en.json	Adds English label map.thestraits = "The Straits" alongside existing map entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🌊 A narrow swell where borders meet,
Flags aligned on every sheet,
Coordinates locked, the tiles align,
The Straits appears — a new design.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'add The Straits map' is clear, concise, and directly summarizes the main change—adding a new map to the game.
Description check	✅ Passed	The description is detailed and directly related to the changeset, explaining the map's theme, location, size, inspiration, and confirming checklist items were completed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@map-generator/assets/maps/thestraits/info.json`:
- Around line 94-99: Remove the stray blank line in the Hanover entry so it
matches the other city objects: locate the object with "name": "Hanover"
(coordinates [219, 1205]) and remove the empty line between the "name" and
"flag" properties so the "flag": "prussia" line directly follows "name":
"Hanover".

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3a587a2d-a18e-4e14-8e45-19cb31b8d4aa

📥 Commits

Reviewing files that changed from the base of the PR and between c0febac and 1bf9d4a.

⛔ Files ignored due to path filters (4)

• map-generator/assets/maps/thestraits/image.png is excluded by !**/*.png
• resources/maps/thestraits/map.bin is excluded by !**/*.bin
• resources/maps/thestraits/map16x.bin is excluded by !**/*.bin
• resources/maps/thestraits/map4x.bin is excluded by !**/*.bin

📒 Files selected for processing (7)

• map-generator/assets/maps/thestraits/info.json
• map-generator/main.go
• resources/lang/en.json
• resources/maps/thestraits/manifest.json
• resources/maps/thestraits/thumbnail.webp
• src/core/game/Game.ts
• src/server/MapPlaylist.ts