Skip to content

New Map: Jamaica 🇯🇲#3570

Open
ewxve wants to merge 7 commits intoopenfrontio:mainfrom
ewxve:main
Open

New Map: Jamaica 🇯🇲#3570
ewxve wants to merge 7 commits intoopenfrontio:mainfrom
ewxve:main

Conversation

@ewxve
Copy link
Copy Markdown

@ewxve ewxve commented Apr 3, 2026

Description:

Added Jamaica as a playable map (with weight 4)

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

@neikirk

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 3, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1af3cecc-c050-4659-9c96-176802732f57

📥 Commits

Reviewing files that changed from the base of the PR and between b04526c and c004328.

📒 Files selected for processing (4)
  • map-generator/main.go
  • resources/lang/en.json
  • src/core/game/Game.ts
  • src/server/MapPlaylist.ts
✅ Files skipped from review due to trivial changes (4)
  • resources/lang/en.json
  • src/server/MapPlaylist.ts
  • src/core/game/Game.ts
  • map-generator/main.go

Walkthrough

Added a new "Jamaica" map: assets and manifest files, map-generator registry entry, game enum/category update, playlist frequency weight, and an English translation key.

Changes

Cohort / File(s) Summary
Map Assets & Manifest
map-generator/assets/maps/jamaica/info.json, resources/maps/jamaica/manifest.json
Added Jamaica map metadata and a manifest: root name, nations array with coordinates, name, flag, and multi-resolution dimensions/tile counts.
Map Generator Registry
map-generator/main.go
Registered jamaica in the generator's maps list.
Game Types & Categories
src/core/game/Game.ts
Added GameMapType.Jamaica and included it in mapCategories.regional.
Playlist Weighting
src/server/MapPlaylist.ts
Added Jamaica: 6 to the map frequency table used by buildMapsList.
Localization
resources/lang/en.json
Added "jamaica": "Jamaica" to English translations.

Sequence Diagram(s)

sequenceDiagram
    participant CLI as CLI/Developer
    participant Generator as Map Generator
    participant Assets as Map Assets
    participant Server as Game Server
    participant Client as Game Client

    CLI->>Generator: run generate/all (includes "jamaica")
    Generator->>Assets: load `map-generator/assets/maps/jamaica/info.json` and `resources/maps/jamaica/manifest.json`
    Assets-->>Generator: return map metadata and tile config
    Generator->>Server: register generated map artifacts
    CLI->>Server: start server / build playlists
    Server->>Server: buildMapsList (reads frequency with Jamaica:6)
    Server-->>Client: include Jamaica in playlists served to clients
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🗺️ Jamaica added to the map’s bright frame,
Flags and coordinates join the game,
Generator loads, the server sings,
Playlists turn on island springs,
Small file, big waves — ready to claim!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding Jamaica as a new playable map to the project.
Description check ✅ Passed The description is relevant to the changeset, explaining that Jamaica was added as a playable map and listing completed checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ewxve ewxve marked this pull request as draft April 3, 2026 07:29
@ewxve ewxve closed this Apr 3, 2026
@github-project-automation github-project-automation Bot moved this from Triage to Complete in OpenFront Release Management Apr 3, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@map-generator/assets/maps/jamaica/info.json`:
- Line 2: Update the map metadata "name" field in the Jamaica map info JSON:
change the value currently set as "Europe" to "Jamaica" in the info.json's
"name" property so the map metadata correctly reflects the Jamaica asset and
prevents incorrect naming during asset regeneration.

In `@resources/maps/jamaica/manifest.json`:
- Line 17: The manifest's "name" property is incorrect (currently "Europe");
update the "name" field in resources/maps/jamaica/manifest.json to "Jamaica" so
consumers reading manifest.name receive the correct map name; locate the JSON
object containing the "name" key and replace its value accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d104567a-b2a8-46a6-806d-c507489b7205

📥 Commits

Reviewing files that changed from the base of the PR and between 21c2861 and 8d8b980.

⛔ Files ignored due to path filters (4)
  • map-generator/assets/maps/jamaica/image.png is excluded by !**/*.png
  • resources/maps/jamaica/map.bin is excluded by !**/*.bin
  • resources/maps/jamaica/map16x.bin is excluded by !**/*.bin
  • resources/maps/jamaica/map4x.bin is excluded by !**/*.bin
📒 Files selected for processing (7)
  • map-generator/assets/maps/jamaica/info.json
  • map-generator/main.go
  • resources/lang/en.json
  • resources/maps/jamaica/manifest.json
  • resources/maps/jamaica/thumbnail.webp
  • src/core/game/Game.ts
  • src/server/MapPlaylist.ts

Comment thread map-generator/assets/maps/jamaica/info.json Outdated
Comment thread resources/maps/jamaica/manifest.json Outdated
@github-project-automation github-project-automation Bot moved this from Complete to Development in OpenFront Release Management Apr 3, 2026
@ewxve ewxve reopened this Apr 3, 2026
@github-project-automation github-project-automation Bot moved this from Development to Triage in OpenFront Release Management Apr 3, 2026
ewxve and others added 2 commits April 3, 2026 01:38
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 3, 2026
@github-project-automation github-project-automation Bot moved this from Triage to Final Review in OpenFront Release Management Apr 3, 2026
@ewxve ewxve marked this pull request as ready for review April 3, 2026 07:55
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 17, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Final Review

Development

Successfully merging this pull request may close these issues.

2 participants