Skip to content

Fix Linux PG installs when the GUI release lacks an unpacked CLI - #8687

Merged
danoli3 merged 1 commit into
openframeworks:masterfrom
danoli3:fix-pg-asar-cli
Nov 18, 2026
Merged

danoli3 merged 1 commit into
openframeworks:masterfrom
danoli3:fix-pg-asar-cli

Conversation

@danoli3

@danoli3 danoli3 commented Nov 18, 2026

Copy link
Copy Markdown
Member

Linux PG GUI installation currently fails with “missing the GUI or bundled CLI” when a GUI release has no native executable at either unpacked CLI path. This blocks callers such as the Android job even though the same PG release publishes a standalone CLI archive.

If the GUI is present but its bundled CLI is missing, download the matching standalone Linux CLI from the same release tag and variant (linux, linux-ubuntu22 or linux-arm64). Install it at the native resource path and as projectGeneratorCmd, preserving the existing GUI install behavior. Complete GUI archives need no additional download. Failed downloads or incomplete archives leave the prior installation intact.

Extend the installer fixtures for the missing-CLI fallback, tag/architecture matching, download failure, corrupt archives and missing executables. Run the regression suite inside the existing Android job.

Validation: python3 scripts/dev/tests/test-download-pg.py passes for Linux, Ubuntu 22, ARM64, macOS and Windows fixtures, including menu discovery and failed-install preservation. bash -n scripts/dev/download_pg.sh and git diff --check pass. Standalone archive layout and asset naming were checked against the PG Linux packaging workflow. Full Android builds run in CI; release binary execution was not tested locally.

@danoli3
danoli3 merged commit 06e37ae into openframeworks:master Nov 18, 2026
30 checks passed
@danoli3
danoli3 deleted the fix-pg-asar-cli branch November 18, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant