Skip to content

release-libs: derive the apothecary release from the OF tag - #8681

Merged
danoli3 merged 1 commit into
openframeworks:masterfrom
danoli3:release-libs-derive-from-tag
Nov 15, 2026
Merged

danoli3 merged 1 commit into
openframeworks:masterfrom
danoli3:release-libs-derive-from-tag

Conversation

@danoli3

@danoli3 danoli3 commented Nov 15, 2026

Copy link
Copy Markdown
Member

Summary

  • scripts/dev/apothecary_release becomes an optional override instead of a required pin.
  • release-libs.yml and download_libs.sh both derive the apothecary release from the OF tag via the existing apothecary_release_tag formula (0.12.2 and 0.12.2-RC1 → v12.2.0).
  • The override still wins when it names an off-formula release (e.g. v12.2.0-hotfix1); latest/empty fall through to the formula. Keeps the escape hatch for hotfixes.
  • download_libs.sh with no -t and no override now reads the git tag at HEAD and derives from that, so a release checkout gets the pinned libraries without a committed pin.
  • release-libs.yml now only errors when the OF ref is not a version tag AND there is no override — eliminates the extra pre-tag commit step.

Why

The 0.12.2-RC1 release-libs run failed with:

0.12.2-RC1 pins 'latest' in scripts/dev/apothecary_release, so download_libs.sh would follow apothecary's moving 'latest'. Commit the release's apothecary tag (e.g. v12.2.0) before tagging.

Nothing was actually missing — v12.2.0 exists at openframeworks/apothecary. The formula in apothecary_release_tag.sh already deterministically maps every release tag to its apothecary release. Requiring a separate pin commit on the release commit is just a foot-gun; the common case can be derived.

Test plan

  • Local: apothecary_release_tag maps 0.12.2, 0.12.2-RC1, v0.12.2-RC1, v12.2.0, v12.2.0-RC1 → v12.2.0; v12.1.1 → v12.1.1; latest/nightly/master unchanged.
  • bash -n passes on scripts/dev/download_libs.sh and scripts/dev/apothecary_release_tag.sh.
  • workflow_dispatch of release-libs.yml with of_tag=0.12.2 passes the resolve step and checks v12.2.0 packages.
  • download_libs.sh on a tagged checkout with no -t prints the "derived from HEAD's tag" line and downloads the right release.
  • download_libs.sh on master (no tag) keeps the current default (master libraries).
  • An override like echo v12.2.0-hotfix1 > scripts/dev/apothecary_release still wins over the formula.

scripts/dev/apothecary_release is now an optional override instead of a
required pin. release-libs.yml and download_libs.sh both use the formula
in apothecary_release_tag.sh to map the OF version to its apothecary
release (0.12.2 and 0.12.2-RC1 -> v12.2.0); scripts/dev/apothecary_release
is read first and wins when it names an off-formula release (e.g.
v12.2.0-hotfix1), but 'latest' and empty fall through to the formula.

download_libs.sh with no -t and no override now looks at the git tag at
HEAD and derives from that, so a release checkout gets the pinned
libraries without a committed pin. release-libs.yml errors only when
the OF ref is not a version tag and there is no override.

Fixes the 0.12.2-RC1 release-libs run that failed on 'pins latest in
scripts/dev/apothecary_release'.
@danoli3
danoli3 merged commit ab58923 into openframeworks:master Nov 15, 2026
29 checks passed
danoli3 added a commit that referenced this pull request Nov 15, 2026
The yaml download-libs step still greps for the old 'pinned by
scripts/dev/apothecary_release: <TAG>' line, but after #8681
download_libs.sh now prints either 'override from ...' or 'derived
from HEAD's tag ...' depending on which path resolved the release, so
the grep fails and the 0.12.2-RC1 release-libs run's download jobs
report failure even though the right libraries install.

Emit a single stable 'Resolved apothecary release: <TAG>' line after
either path, and match that line in release-libs.yml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant