Repository navigation
release-libs: derive the apothecary release from the OF tag - #8681
Merged
danoli3 merged 1 commit intoNov 15, 2026
Merged
Conversation
scripts/dev/apothecary_release is now an optional override instead of a required pin. release-libs.yml and download_libs.sh both use the formula in apothecary_release_tag.sh to map the OF version to its apothecary release (0.12.2 and 0.12.2-RC1 -> v12.2.0); scripts/dev/apothecary_release is read first and wins when it names an off-formula release (e.g. v12.2.0-hotfix1), but 'latest' and empty fall through to the formula. download_libs.sh with no -t and no override now looks at the git tag at HEAD and derives from that, so a release checkout gets the pinned libraries without a committed pin. release-libs.yml errors only when the OF ref is not a version tag and there is no override. Fixes the 0.12.2-RC1 release-libs run that failed on 'pins latest in scripts/dev/apothecary_release'.
danoli3
added a commit
that referenced
this pull request
Nov 15, 2026
The yaml download-libs step still greps for the old 'pinned by scripts/dev/apothecary_release: <TAG>' line, but after #8681 download_libs.sh now prints either 'override from ...' or 'derived from HEAD's tag ...' depending on which path resolved the release, so the grep fails and the 0.12.2-RC1 release-libs run's download jobs report failure even though the right libraries install. Emit a single stable 'Resolved apothecary release: <TAG>' line after either path, and match that line in release-libs.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/dev/apothecary_releasebecomes an optional override instead of a required pin.release-libs.ymlanddownload_libs.shboth derive the apothecary release from the OF tag via the existingapothecary_release_tagformula (0.12.2and0.12.2-RC1→v12.2.0).v12.2.0-hotfix1);latest/empty fall through to the formula. Keeps the escape hatch for hotfixes.download_libs.shwith no-tand no override now reads the git tag atHEADand derives from that, so a release checkout gets the pinned libraries without a committed pin.release-libs.ymlnow only errors when the OF ref is not a version tag AND there is no override — eliminates the extra pre-tag commit step.Why
The 0.12.2-RC1 release-libs run failed with:
Nothing was actually missing —
v12.2.0exists atopenframeworks/apothecary. The formula inapothecary_release_tag.shalready deterministically maps every release tag to its apothecary release. Requiring a separate pin commit on the release commit is just a foot-gun; the common case can be derived.Test plan
apothecary_release_tagmaps0.12.2,0.12.2-RC1,v0.12.2-RC1,v12.2.0,v12.2.0-RC1→v12.2.0;v12.1.1→v12.1.1;latest/nightly/masterunchanged.bash -npasses onscripts/dev/download_libs.shandscripts/dev/apothecary_release_tag.sh.workflow_dispatchofrelease-libs.ymlwithof_tag=0.12.2passes the resolve step and checksv12.2.0packages.download_libs.shon a tagged checkout with no-tprints the "derived from HEAD's tag" line and downloads the right release.download_libs.shonmaster(no tag) keeps the current default (master libraries).echo v12.2.0-hotfix1 > scripts/dev/apothecary_releasestill wins over the formula.