Make deeplinks in history selectable#518
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables text selection for the deeplink history list by wrapping items in a SelectionContainer. Feedback suggests adding a unique key to the items in the LazyColumn for improved performance and state management. Additionally, it is recommended to move the SelectionContainer to a higher level to allow for continuous text selection across multiple items and to improve overall efficiency.
| variableValues = variableValues, | ||
| modifier = Modifier.fillMaxWidth(), | ||
| ) | ||
| SelectionContainer { |
There was a problem hiding this comment.
Placing SelectionContainer inside the items block creates a separate selection context for each row. This prevents users from selecting text across multiple items and is less efficient than using a single container for the whole list. Additionally, this approach is inconsistent as it only applies to the History section and not the main Deeplinks list.
Consider moving the SelectionContainer to a higher level (e.g., wrapping the LazyColumn inside DeeplinkScrollablePanel) to provide a better user experience and improved performance.
2 participants
Hi,
I have a small improvement for the new deeplink screen. I often find myself wanting to copy a deeplink from the history and paste it into the free form text field to edit and send it. Currently the deeplinks are not selectable, so they can't be copied. Adding a SelectionContainer around the history items makes this possible.