Conversation
This comment has been minimized.
This comment has been minimized.
For the sake of agent-friendliness - adds structured output for consumption from ad-hoc bash/Python scripts, direct parsing etc. Tested by Qwen 3.6 27B against openfaas edge installation to show that the original did not revert, and the new behaviour is in place. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
This comment has been minimized.
This comment has been minimized.
When secret gen goes into a file, we don't want a newline trailing as many programs will pipe this file into i.e. a curl header. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project. Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken. 💡 Shall we fix this?This will only take a few moments. First, clone your fork and checkout this branch using the git CLI. Next, set up your real name and email address:
Finally, run one of these commands to add the "Signed-off-by" line to your commits. If you only have one commit so far then run: Check that the message has been added properly by running "git log". |
This comment has been minimized.
This comment has been minimized.
* Uses Go 1.26 to build Go code * Adds basic AGENTS.md Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
AI Pull Request OverviewDisclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification. Summary
Approval rating (1-10)7/10. The feature is useful, but namespace JSON output needs fixes before it is reliable across supported namespace-listing entry points. Summary per fileSummary per file
Overall AssessmentThe implementation mostly follows the existing command structure and keeps the text output paths intact. The main issue is that namespace JSON support is incomplete: Detailed ReviewDetailed ReviewFindingsMedium:
|
Description
Add --json/-j to most get/list commands
Motivation and Context
For the sake of agent-friendliness - adds structured output for consumption from ad-hoc bash/Python scripts, direct parsing etc.
How Has This Been Tested?
Tested by Qwen 3.6 27B against openfaas edge installation to show that the original did not revert, and the new behaviour is in place.
Types of changes
Checklist:
Remains in Cobra help messages for now - not separately on docs site - but will include in agent-skills when released for the openfaas-function-developer skill.
https://github.com/openfaas/agent-skills