-
Notifications
You must be signed in to change notification settings - Fork 12
OEL-4185: Improved mega menu. #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Deployed on https://preview-702--oelibrary.netlify.app |
donquixote
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am submitting the review now so it is not lost.
@tibi2303 already told me he is working on some changes.
d3d6c2e to
bd3e523
Compare
13babdc to
fb37098
Compare
032b4f9 to
cbc9570
Compare
donquixote
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tibi2303 I left some comments but also pushed some commits.
Let me know if you agree with these.
4246ded to
8ab98ba
Compare
donquixote
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions, but overall it works and looks good. Nice work!
donquixote
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
But let'd do UAT release before we merge.
No description provided.