libuio: fix FILE descriptor leak#1053
Open
Qliangw wants to merge 2 commits into
Open
Conversation
This patch is not right and moreover not needed anymore with latest clang Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
The function uio_line_from_file() fails to close the FILE pointer when fgets() returns NULL, causing a file descriptor leak. This can be triggered when reading from /sys files that return empty content, leading to resource exhaustion over time. Fix this by using goto-based error handling to ensure fclose() is called on all exit paths. Signed-off-by: Qliangw <qili00001@gmail.com>
halstead
force-pushed
the
master-next
branch
18 times, most recently
from
bbb28db to
ccba300
Compare
halstead
force-pushed
the
master-next
branch
2 times, most recently
from
439d5e5 to
041a530
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function uio_line_from_file() fails to close the FILE pointer when fgets() returns NULL, causing a file descriptor leak.
This can be triggered when reading from /sys files that return empty content, leading to resource exhaustion over time.
Fix this by using goto-based error handling to ensure fclose() is called on all exit paths.