fix: add parent property to avoid dynamic property#109
fix: add parent property to avoid dynamic property#109felipemontoya merged 2 commits intoopenedx:mainfrom
Conversation
|
Thanks for the pull request, @MaferMazu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
d948c92 to
817caab
Compare
817caab to
fda7b16
Compare
felipemontoya
left a comment
There was a problem hiding this comment.
I was about to fix this in #111. So I'll merge here
Description
Adds "parent" property to avoid dynamic property creation.
This solves #106
Details
We were assigning a value to a property called "parent"
openedx-wordpress-ecommerce/includes/model/class-openedx-commerce-enrollment.php
Line 58 in e0e636e
but it wasn't defined before.
In this PR, I only define a property called "parent" to avoid the dynamic property creation.
And also update the tested up version in the docs.
Testing instructions
Live link: https://openecommtest.s6-tastewp.com/wp-admin/
I already uploaded the plugin with this version.
Credentials
adminP^C)W)DOrPa&^KYsOvY8x2P3
Or you can use this branch to run
make release, and compress theopenedx-commercefolder as a ZIP file. Use that as a plugin to upload to your WordPress environment, and you can also upload to the test live site.Everything should work as expected.
Additional information
Before the PR

https://github.com/openedx/openedx-wordpress-ecommerce/actions/runs/12168160490/job/34157245826?pr=104
After the PR

https://github.com/openedx/openedx-wordpress-ecommerce/actions/runs/13681127038/job/38253515240?pr=109
Checklist for Merge