Skip to content

fix: make the enrollment v2 schema match with API returns #39120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Faraz32123 wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −4
Draft

fix: make the enrollment v2 schema match with API returns #39120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions openedx/core/djangoapps/enrollments/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,13 @@ class CourseSerializer(serializers.Serializer): # pylint: disable=abstract-meth

course_id = serializers.CharField(source="id")
course_name = serializers.CharField(source="display_name_with_default")
enrollment_start = serializers.DateTimeField(format=None)
enrollment_end = serializers.DateTimeField(format=None)
course_start = serializers.DateTimeField(source="start", format=None)
course_end = serializers.DateTimeField(source="end", format=None)
# These are null for courses with no dates set, so they must be declared
# nullable — otherwise the published schema tells every generated client
# the fields are always present and parsing null raises.
enrollment_start = serializers.DateTimeField(format=None, allow_null=True)
enrollment_end = serializers.DateTimeField(format=None, allow_null=True)
course_start = serializers.DateTimeField(source="start", format=None, allow_null=True)
course_end = serializers.DateTimeField(source="end", format=None, allow_null=True)
invite_only = serializers.BooleanField(source="invitation_only")
course_modes = serializers.SerializerMethodField()
pacing_type = serializers.SerializerMethodField()
Expand Down
4 changes: 4 additions & 0 deletions openedx/core/djangoapps/enrollments/v2/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,10 @@ def unenroll(self, request):
url_path="enrollment_allowed",
permission_classes=[permissions.IsAdminUser],
throttle_classes=[EnrollmentUserThrottle],
# GET returns a plain list. Actions inherit the viewset's
# pagination_class, which would otherwise make drf-spectacular publish
# a paginated envelope this endpoint never returns.
pagination_class=None,
)
def allowed(self, request):
"""Retrieve, create, or delete CourseEnrollmentAllowed records. Admin-only."""
Expand Down
Loading