Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions credentials/apps/api/v2/tests/test_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -691,3 +691,17 @@ def test_existing_and_non_existing_users(self):
response = self.call_api(self.service_user, data)
self.assertEqual(response.status_code, 200)
self.assertEqual(response.data, expected_response)

def test_clears_full_name_for_replaced_user(self):
"""Verify username replacement clears PII fields (matching LMS retirement pattern with empty strings)."""
user = UserFactory(full_name="Jane Example", first_name="Jane", last_name="Example")
new_username = f"{user.username}_retired"

response = self.call_api(self.service_user, {"username_mappings": [{user.username: new_username}]})

self.assertEqual(response.status_code, 200)
user.refresh_from_db()
self.assertEqual(user.username, new_username)
self.assertEqual(user.full_name, "")
self.assertEqual(user.first_name, "")
self.assertEqual(user.last_name, "")
11 changes: 8 additions & 3 deletions credentials/apps/api/v2/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,14 @@ def _replace_username_for_all_models(self, current_username, new_username, repla
with transaction.atomic():
num_rows_changed = 0
for model, column in replacement_locations:
num_rows_changed += model.objects.filter(**{column: current_username}).update(
**{column: new_username}
)
update_kwargs = {column: new_username}
# Clear PII fields for user retirement to match LMS retirement pattern
# (empty strings, not "redacted" - that's used in cleanup phase later)
if model._meta.label_lower == "core.user" and column == "username":
update_kwargs["full_name"] = ""
update_kwargs["first_name"] = ""
update_kwargs["last_name"] = ""
num_rows_changed += model.objects.filter(**{column: current_username}).update(**update_kwargs)
except Exception as exc:
log.exception(
"Unable to change username from %s to %s. Failed on table %s because %s",
Expand Down