Take odrcore 6.10.1 - #181
Merged
Merged
Conversation
Pictures in a Word or Excel file came out as a broken image. The app asks for images to be served rather than written into the page, and those were the ones named in a way the page could not fetch. Nothing to wire: the fix is inside the core. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BbPD7h7jANgG3LWuTjmYYA
andiwand
marked this pull request as ready for review
August 21, 2026 09:17
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70e40954e9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BbPD7h7jANgG3LWuTjmYYA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
odrcore 6.10.0 → 6.10.1, resolved against the tag.
What it takes
The one change in the release is opendocument-app/OpenDocument.core#727: a linked image in a docx or xlsx is named relative to the document, as odf already did.
That is not a corner case here. The app asks for images to be served rather than written into the page (
embedImages = false), and serves them from odrcore's own server under/file/<prefix>/. The ooxml engines resolved an image relationship to an absolute container path —/word/media/image1.jpeg— whichresource_atmatches against the request path by exact string, so it never matched. Every picture in a Word or Excel file is a broken image in the app today, in 1.41 and in 1.42 as it stands. ODF was always fine, which is what hid it.Taken from the core's own regression test and the app's configuration, not observed on a device: the screenshot documents carry no images, so nothing here shows it.
Nothing to wire — the fix is entirely inside the core.
Worth knowing before 1.42
This is the reason to hold the release rather than cut it now.