Repository navigation
fix: large dataset downloads time out; local-only builds continue the sequence - #3
Merged
Merged
Conversation
…; local-only --prev continues the sequence The single 30s Client.Timeout failed the ~18 MB bounty-targets files. Keep header/connect/TLS timeouts, replace the whole-request timeout with a context deadline that dataset adapters raise to 5 min, and fail a body that stalls for 20s. build --local-only now accepts --prev <local bundle> (unsigned, snapshot-only, still local_only) so local sequences increase; signed and local bundles are refused as each other's prev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bounty-targets failing with Client.Timeout while reading body (18 MB files). Per-request context deadline (default 30s, dataset adapters 5 min), 20s idle-read guard, size caps unchanged. Adds --prev for --local-only (prev must be an unsigned local-only bundle; signed releases and local bundles are refused as each other's prev). Tests: slow-but-steady body passes, stalled body fails, ReadLocal round trip/tamper/refusals. Live check: bounty-targets 943 programs; local build sequence 1 then 2.