Skip to content

generate: key envMap by variable name rather than full env string #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crawfordxx wants to merge 1 commit into
base: master
Choose a base branch
from
Open

generate: key envMap by variable name rather than full env string #810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions generate/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,11 +318,14 @@ func NewFromTemplate(r io.Reader) (Generator, error) {
}, nil
}

// createEnvCacheMap creates a hash map with the ENV variables given by the config
// createEnvCacheMap creates a hash map with the ENV variables given by the config.
// The map is keyed by the variable name (the part before the first '=') so that
// addEnv can look up existing entries by name and replace them in-place.
func createEnvCacheMap(env []string) map[string]int {
envMap := make(map[string]int, len(env))
for i, val := range env {
envMap[val] = i
name, _, _ := strings.Cut(val, "=")
envMap[name] = i
}
return envMap
}
Expand Down