enhance: send events for adding/removing favourite items - #3229
Open
schweigisito wants to merge 1 commit into
Open
enhance: send events for adding/removing favourite items#3229schweigisito wants to merge 1 commit into
schweigisito wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | -38 |
🟢 Coverage 0.00% diff coverage · -0.02% coverage variation
Metric Results Coverage variation ✅ -0.02% coverage variation (-1.00%) Diff coverage ✅ 0.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (b9adb50) 83834 19269 22.98% Head commit (43c0c6c) 83856 (+22) 19257 (-12) 22.96% (-0.02%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3229) 22 0 0.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR may fix #2933 and provides the events for web UI being able to react on favourite events (as also reported in opencloud-eu/web#3016
Enhancement: Send SSE events when items are added to or removed from favourites
Currently, marking or unmarking a resource as a favourite does not notify connected web clients, so favourite state changes made in one browser tab or on another device only becomes visible after a manual reload. The graph service already published
LabelAdded/LabelRemovedevents on the event bus for this; the clientlog service now also consumes them and forwardsitem-favorite-added/item-favorite-removedSSE notifications to the affected user, mirroring how renames and moves are already announced.Related Issue
Motivation and Context
Making web UI react on favourite changes, backend needs to generate and send events.
How Has This Been Tested?
ssebrowser connection of a logged-in user and watched foritem-favorite-removedanditem-favorite-addedeventsScreenshots (if appropriate):
Types of changes
Checklist: