Sanitize web config only once #2286
Merged
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@micbar @ScharfViktor it seems I can't add labels here. |
Contributor
really? Is this available after clicking by label? 
label check is skipped for PR from fork. but you should be able add label |
Member
|
@VicDeo You are onto sth here. But I am not really happy with your implementation, instead of using the |
dragonchaser
requested changes
Feb 6, 2026
Member
dragonchaser
left a comment
dragonchaser
left a comment
There was a problem hiding this comment.
Please add explicit nil-checks instead of a bool workaround.
VicDeo
force-pushed
the
bugfix/issue-2271
branch
from
14a86ea to
6a271cd
Compare
Contributor
Author
|
@dragonchaser done |
|
Member
|
Looks good, have approved CI-Run, waiting for it to turn green :) |
dragonchaser
approved these changes
Feb 9, 2026
Member
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suture restarts failing service by executing the respective command. Cobra tries to execute PreRunE one more time that triggers config sanitization for already sanitized config.
Checking against an empty string triggers panic.
Related Issue
Motivation and Context
It makes the world a better place to live and fixes the panic if the port 9200 is already taken.
P.S. Execute
web.Execute(cfg.Web)command producesUsage:message in CLI on every restart on opencloud/pkg/runtime/service/service.go:264 so there are 5 such messages in console but that's completely different story.How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: