Shares: Honor write/delete permissions inside shared folders#194
Open
paolostivanin wants to merge 1 commit into
Open
Shares: Honor write/delete permissions inside shared folders#194paolostivanin wants to merge 1 commit into
paolostivanin wants to merge 1 commit into
Conversation
The "Shares" bottom-bar tab navigates with FileListOption.SHARED_BY_LINK, which treated every screen under it as a flat list. As a result the FAB and the Remove/Rename/Move menu items were hidden even when standing inside a folder shared with full Create/Change/Delete permissions. Restrict the flat-list assumption to the root: show the FAB inside SHARED_BY_LINK sub-folders when the folder grants add-file/subdirectory permission, and let onlySharedByLinkFiles flag only at the root so the file's own permissions gate Remove/Rename/Move. Fixes opencloud-eu#193
guruz
approved these changes
Jun 15, 2026
Author
|
Forgot to mention: tested on latest master. Been using this for a few days with 3 users and it works fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Shares" bottom-bar tab navigates with FileListOption.SHARED_BY_LINK, which treated every screen under it as a flat list. As a result the FAB and the Remove/Rename/Move menu items were hidden even when standing inside a folder shared with full Create/Change/Delete permissions.
Restrict the flat-list assumption to the root: show the FAB inside SHARED_BY_LINK sub-folders when the folder grants add-file/subdirectory permission, and let onlySharedByLinkFiles flag only at the root so the file's own permissions gate Remove/Rename/Move.
Fixes #193