Skip to content

feat(mapper): preserve node route mount prefixes #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohitjavvadi wants to merge 2 commits into
base: main
Choose a base branch
from
+482 −16
Open

feat(mapper): preserve node route mount prefixes #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a69a00
feat(mapper): preserve node route mount prefixes
rohitjavvadi May 20, 2026
5c3f77a
fix(mapper): handle generic middleware mounts
rohitjavvadi May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
178 changes: 178 additions & 0 deletions src/mapper.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2852,6 +2852,184 @@ describe("mapFeatures", () => {
expect(routes.some((route) => route.endsWith(" /template-dynamic"))).toBe(false);
});

it("preserves literal Express and Hono mount prefixes for child routes", async () => {
const root = await fixtureRoot("clawpatch-node-mounted-route-prefixes-");
await writeFixture(
root,
"package.json",
JSON.stringify(
{
name: "mounted-route-server",
dependencies: { express: "1.0.0", hono: "1.0.0" },
},
null,
2,
),
);
await writeFixture(
root,
"src/express-mounted.ts",
[
"import express, { Router } from 'express';",
"",
"const app = express();",
"const apiApp = express();",
"const router = Router();",
"const nestedRouter = Router();",
"const middlewareRouter = Router();",
"const genericMiddlewareRouter = Router();",
"const asyncMiddlewareRouter = Router();",
"const pathlessRouter = Router();",
"const directPathlessRouter = Router();",
"const arrayRouter = Router();",
"const wildcardRouter = Router();",
"const dynamicRouter = Router();",
"const dynamicParent = Router();",
"const dynamicChild = Router();",
"const tenantRouter = Router();",
"const falseRouter = Router();",
"const notApp = createClient();",
"app.use('/api', router);",
"app.use(dynamicTenant, router);",
"app.use('/service', apiApp);",
"router.use('/v1', nestedRouter);",
"app.use('/middleware', requireAuth, middlewareRouter);",
"apiApp.use(mw, genericMiddlewareRouter);",
"apiApp.use(amw, asyncMiddlewareRouter);",
"apiApp.use(requireAuth, pathlessRouter);",
"apiApp.use(directPathlessRouter);",
"app.use(['/array', '/alt-array'], arrayRouter);",
"app.use('*', wildcardRouter);",
"app.use(dynamicPrefix, dynamicRouter);",
"app.use(dynamicBase, dynamicParent);",
"dynamicParent.use('/v1', dynamicChild);",
"app.use(tenant, tenantRouter);",
"notApp.use('/false', falseRouter);",
"router.get('/users', listUsers);",
"router.route('/reports').get(listReports);",
"nestedRouter.post('/teams', createTeam);",
"apiApp.delete('/sessions/:id', deleteSession);",
"middlewareRouter.get('/users', listMiddlewareUsers);",
"genericMiddlewareRouter.get('/generic-middleware-users', listGenericMiddlewareUsers);",
"asyncMiddlewareRouter.get('/async-middleware-users', listAsyncMiddlewareUsers);",
"pathlessRouter.get('/pathless-users', listPathlessUsers);",
"directPathlessRouter.get('/direct-pathless-users', listDirectPathlessUsers);",
"arrayRouter.get('/array-users', listArrayUsers);",
"wildcardRouter.get('/wildcard-users', listWildcardUsers);",
"dynamicRouter.get('/dynamic-users', dynamicUsers);",
'dynamicChild.get("/dynamic-child-users", dynamicChildUsers);',
'tenantRouter.get("/tenant-users", tenantUsers);',
"falseRouter.get('/false-users', falseUsers);",
"function createClient() { return { use() {} }; }",
"function listUsers() {}",
"function listReports() {}",
"function createTeam() {}",
"function deleteSession() {}",
"function requireAuth() {}",
"function mw() {}",
"async function amw() {}",
"function listMiddlewareUsers() {}",
"function listGenericMiddlewareUsers() {}",
"function listAsyncMiddlewareUsers() {}",
"function listPathlessUsers() {}",
"function listDirectPathlessUsers() {}",
"function listArrayUsers() {}",
"function listWildcardUsers() {}",
"function dynamicUsers() {}",
"function dynamicChildUsers() {}",
"function tenantUsers() {}",
"function falseUsers() {}",
"",
].join("\n"),
);
await writeFixture(
root,
"src/hono-mounted.ts",
[
"import { Hono } from 'hono';",
"",
"const app = new Hono();",
"const subApp = new Hono();",
"const nestedSubApp = new Hono();",
"const dynamicSubApp = new Hono();",
"const falseSubApp = new Hono();",
"const client = createClient();",
"app.route('/api', subApp);",
"subApp.route('/v1', nestedSubApp);",
"app.route(dynamicPrefix, dynamicSubApp);",
"client.route('/false', falseSubApp);",
"subApp.get('/users', listUsers);",
"nestedSubApp.delete('/sessions/:id', deleteSession);",
"dynamicSubApp.get('/dynamic-users', dynamicUsers);",
"falseSubApp.get('/false-users', falseUsers);",
"function createClient() { return { route() {} }; }",
"function listUsers() {}",
"function deleteSession() {}",
"function dynamicUsers() {}",
"function falseUsers() {}",
"",
].join("\n"),
);
await writeFixture(
root,
"src/express-dynamic-mw.ts",
[
"import express, { Router } from 'express';",
"",
"const app = express();",
"const router = Router();",
"const mw = dynamicPrefix;",
"app.use(mw, router);",
"router.get('/dynamic-mw-users', listDynamicMwUsers);",
"function listDynamicMwUsers() {}",
"",
].join("\n"),
);

const project = await detectProject(root);
const result = await mapFeatures(root, project, []);
const titles = result.features.map((feature) => feature.title);

expect(titles).toEqual(
expect.arrayContaining([
"Express route GET /api/users",
"Express route GET /api/reports",
"Express route POST /api/v1/teams",
"Express route DELETE /service/sessions/:id",
"Express route GET /middleware/users",
"Express route GET /service/generic-middleware-users",
"Express route GET /service/async-middleware-users",
"Express route GET /service/pathless-users",
"Express route GET /service/direct-pathless-users",
"Express route GET /array/array-users",
"Express route GET /alt-array/array-users",
"Express route GET /*/wildcard-users",
"Hono route GET /api/users",
"Hono route DELETE /api/v1/sessions/:id",
]),
);
expect(titles).not.toContain("Express route GET /users");
expect(titles).not.toContain("Express route GET /reports");
expect(titles).not.toContain("Express route POST /v1/teams");
expect(titles).not.toContain("Express route DELETE /sessions/:id");
expect(titles).not.toContain("Express route GET /false/false-users");
expect(titles).not.toContain("Express route GET /generic-middleware-users");
expect(titles).not.toContain("Express route GET /async-middleware-users");
expect(titles).not.toContain("Express route GET /pathless-users");
expect(titles).not.toContain("Express route GET /direct-pathless-users");
expect(titles).not.toContain("Express route GET /array-users");
expect(titles).not.toContain("Express route GET /wildcard-users");
expect(titles).not.toContain("Express route GET /dynamic-users");
expect(titles).not.toContain("Express route GET /dynamic-child-users");
expect(titles).not.toContain("Express route GET /dynamic-mw-users");
expect(titles).not.toContain("Express route GET /tenant-users");
expect(titles).not.toContain("Express route GET /v1/dynamic-child-users");
expect(titles).not.toContain("Hono route GET /users");
expect(titles).not.toContain("Hono route GET /dynamic-users");
expect(titles).not.toContain("Hono route DELETE /v1/sessions/:id");
expect(titles).not.toContain("Hono route GET /false/false-users");
});

it("keeps index route tests scoped to their route directory", async () => {
const root = await fixtureRoot("clawpatch-node-server-index-route-tests-");
await writeFixture(
Expand Down
Loading