Skip to content

chore(nodejs): bump the pinned pnpm 10.33.4 -> 10.34.6 + regression check #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aitrawog wants to merge 3 commits into from
Closed

chore(nodejs): bump the pinned pnpm 10.33.4 -> 10.34.6 + regression check #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78d74b2
chore(nodejs): bump the pinned pnpm 10.33.4 -> 10.34.6
aitrawog Oct 7, 2026
e9a80aa
test(nodejs): assert the installed pnpm is at least 10.34.6 (fails at…
aitrawog Oct 7, 2026
881d45e
test(nodejs): compare all three pnpm version components (the check en…
aitrawog Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ with a working `--version`, so the runtime is directly verifiable.
|---|---|
| Layer / candy | `nodejs` |
| Binaries | `/usr/bin/node`, `/usr/bin/npm`, `/usr/local/bin/pnpm` |
| Pinned pnpm | `PNPM_VERSION` `10.33.4` |
| Pinned pnpm | `PNPM_VERSION` `10.34.6` |
| Env | `NPM_CONFIG_PREFIX=~/.npm-global`; `~/.npm-global/bin` on `PATH` |
| Service / port | none |

Expand Down
15 changes: 14 additions & 1 deletion charly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ nodejs:
suite: nodistro
components: main
var:
PNPM_VERSION: "10.33.4"
PNPM_VERSION: "10.34.6"
plan:
- run: |
command=case "${BUILD_ARCH}" in
Expand Down Expand Up @@ -118,6 +118,19 @@ nodejs:
# with it and hand the result to env(1).
command: |
env HOME="$(getent passwd "$(id -u)" | cut -d: -f6)" pnpm --version
- # The pnpm floor consumers depend on: 10.33.4 cannot accept the
# fully-qualified `allowBuilds` key that pnpm itself prints for a
# git-hosted dependency (ERR_PNPM_INVALID_VERSION_UNION), which breaks
# a DSH profile installing its git-hosted plugins (pod-dsh's dsh-web),
# and it ships no node-gyp for native addon builds. Assert the installed
# binary is at least 10.34.6 so a regression of PNPM_VERSION fails THIS
# check. ALL THREE components are compared, not just major.minor: a
# `10.34.x<6` pin must fail too, or the guard would not enforce the
# stated floor.
check: the installed pnpm is at least 10.34.6 (the git-hosted allowBuilds key floor)
exit_status: 0
command: |
env HOME="$(getent passwd "$(id -u)" | cut -d: -f6)" pnpm --version | node -e 'let s="";process.stdin.on("data",d=>s+=d).on("end",()=>{const v=s.trim().split(".").map(Number);if(v[0]>10||(v[0]===10&&(v[1]>34||(v[1]===34&&v[2]>=6))))process.exit(0);process.exit(1)})'
- check: package=nodejs
id: nodejs-package
package:
Expand Down
Loading