Repository navigation
Conversation
Review — BLOCKHead SHA: Change class: code/config — a runtime artifact pin bump ( Blocks
Note (not blocking on its own): R1's root cause (pinned-binary skew) is named, and the fix-forward framing is reasonable — but that does not substitute for the executed evidence the tier and R10 require. No maintainer sign-off is present, and none is asserted to cover the missing evidence. Verdict: BLOCK ollama-cloud/deepseek-v4.1-flash — action-review. |
bcb31b8 to
78d74b2
Compare
Review — BLOCKHead SHA: Change class: config — a runtime artifact pin bump ( Security screen: PASS (no secrets/egress, no guardrail or rulebook edits, no embedded directives; the pin bump is the declared change). Blocks
Comment dispositions
Verdict: BLOCK ollama-cloud/deepseek-v4.1-flash — action-review. |
Review — BLOCKHead SHA: Change class: config — a runtime artifact pin bump ( Security screen: PASS (no secrets/egress, no guardrail or rulebook edits, no embedded directives; the 2-file diff matches the declared change). Blocks
Comment dispositions
Verdict: BLOCK ollama-cloud/deepseek-v4.1-flash — action-review. |
Review — BLOCKHead SHA: Change class: config — a runtime artifact pin bump ( Blocks
Comment dispositions
Verdict: BLOCK ollama-cloud/deepseek-v4.1-flash — action-review. |
Review — BLOCKHead SHA: Change class: config — a runtime artifact pin bump ( Blocks
Comment dispositions
Verdict: BLOCK ollama-cloud/deepseek-v4.1-flash — action-review. |
Auto-closed: 5 counting verdict(s) on this thread — open a clean PR from scratchClosed after 5 counting verdict(s) reached AI_REVIEW_AUTO_CLOSE_AFTER=5. Verdicts on this thread: 5 The rule: open a clean pull request from scratch — a fresh branch and a fresh thread — once the counting verdicts reach 5. Never another push, re-run, or re-open on this thread. Why: every further run on this thread spends a full verdict to say nothing new, and grows this PR's comment thread — which is what drives the reviewer into a runaway. The loop is bounded here instead. What to do:
This is a policy action, not a code finding — the validator verdict on this run stands. |
|
RESOLVED — superseded by This thread auto-closed at the validator's verdict bound (5 countings). Every
This closed thread is no longer acted on; continue on #4. Agent: |
Summary
Bump the pinned standalone
pnpmbinary from10.33.4to10.34.6, and add aregression
check:asserting the installed pnpm is at least10.34.6.Changed paths:
charly.yml—PNPM_VERSION10.33.4 → 10.34.6; a newcheck:step(
the installed pnpm is at least 10.34.6 (the git-hosted allowBuilds key floor))that exits 1 on
10.33.4and 0 on10.34.6.README.md— the pinned-pnpm row (10.33.4 → 10.34.6).Why
10.33.4cannot accept the fully-qualifiedallowBuildskey that pnpm itselfprints for a git-hosted dependency, so a DSH profile that allowlists its
git-hosted plugins that way fails in-image:
10.34.6accepts the same key. The immediate consumer ispod-dsh'sdsh-webcandy, which installs a web profile carrying three git-hosted plugins
(
opencharly/dsh-github,dsh-git-worktree,dsh-workspace-enhancement) andallowlists them by the fully-qualified key pnpm prints. That config built on a
developer host (pnpm 10.34.6) but failed inside the image (pnpm 10.33.4).
10.34.6additionally suppliesnode-gypto the install's native steps; on10.33.4ssh2's optional crypto binding andcpu-featuressilently fail tobuild (
sh: node-gyp: command not found).How tested
Fresh rebuild, on the final tree, of the consumer image that carries this pin.
dsh-appcomposeslayer-nodejsand runs the build-time profile install that thepin governs. Built with this branch as its
layer-nodejs(a session-local,uncommitted local override — no tag minted, no pin hand-edited):
The R10 gate for a
layer-nodejschange is the consumer image build. Thecheck-dsh-podbed (markeddisposable: true) runs exactly that as itsimage-buildstep, and both of its first two steps pass at zero warnings on thefinal tree:
The new in-candy
check:is the regression guard: it exits non-zero at10.33.4and zero at10.34.6, so a futurePNPM_VERSIONregression fails thebuild rather than silently breaking the consumer's install.
The bed's later
configstep is a separately-tracked defect, not a parking ofthis cutover. It aborts for an unrelated reason (the deploy key resolved as the
box name →
image not found in local storage: check-dsh-pod:check-dsh-pod-<calver>vs the built
dsh-app:check-dsh-pod-<calver>), reproduced identically onunmodified
origin/main, and is now routed with that reproduction toopencharly/pod-dsh#23 (the repo that owns the bed). It does not touch
layer-nodejsand is not this PR's to fix.R5 sweep (executed)
The only surviving occurrences are the two explanatory comment lines that name
the failing version on purpose; the version pin itself (
PNPM_VERSION) and theREADME.mdrow are both10.34.6:Rulebook compliance
10.33.4versus the current10.34.6), not a config defect; measured in-image.config-step box-name resolution) is routed to its named owner batch,check-dsh-pod config step fails: deploy key resolved as box name (image not found in local storage) pod-dsh#23, with a reproduction — not parked as "unrelated".
layer-nodejscandy; one regression check.old binary's bug.
README.mdpin row) move with the code in the same commit.README; only deliberate comments naming the failing version remain.
no hook bypass, no direct push to
main.path (the profile install at the new pin) executed live; the new check fails
without the bump.
pnpmbinary) is exercised at itsboundary:
pnpm --version=10.34.6inside the built image.charly box build dsh-app, the bed'simage-buildstep) ran fresh on the final tree at 0 warnings, and thepin-consuming install executed in the resulting image. The bed's subsequent
configstep is blocked by the separately-tracked defect above (pod-dsh#23).RDD — the high-risk assumption (10.34.6 accepts the printed key and builds the
native bits in-image) was proven on a real disposable image before landing.
SDD/ADE — N/A (no schema, no candy plan in this repo).
Change classification
Dependency pin bump (runtime artifact version) plus a regression check. No schema
or wire change. Attribution tier:
analysed on a live system— the changed pathran live against a fresh rebuild.
Assisted-by: OpenCode ollama-cloud deepseek-v4.1-flash (analysed on a live system)