Fix missing pull-down on OBS Pro and remove double button pin initial…#391
Open
FabianSchwartau wants to merge 1 commit intoopenbikesensor:mainfrom
Open
Fix missing pull-down on OBS Pro and remove double button pin initial…#391FabianSchwartau wants to merge 1 commit intoopenbikesensor:mainfrom
FabianSchwartau wants to merge 1 commit intoopenbikesensor:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We forgot to add a pull-down resistor on the current OBS Pro prototypes. This patch enables the internal pull-down, which fixed this. This should not affect the classic, as it also uses an (external) pull-down. The internal is much weaker (42k) than the external (10k).
This fixes the long delay of button presses and probably other problems related to the button and flashing (as the button uses a strapping-pin).
I also removed a double-initialization of the button pin.