Cleanup fetch_file_cached() operations in the download model#44
Open
Arkay92 wants to merge 6 commits intoopenai:mainfrom
Open
Cleanup fetch_file_cached() operations in the download model#44Arkay92 wants to merge 6 commits intoopenai:mainfrom
Arkay92 wants to merge 6 commits intoopenai:mainfrom
Conversation
|
Hello,
|
Author
|
My bad good spot graham will undo with a new commit |
|
You're very welcome ! Also on a point of personal preference I would remove code comments which say what the code is doing - that should be clear from the code. I think comments should explain why and the code itself should be clear. For instance the comment below is not needed because the code itself is very clear: # Return local path
return local_path |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old data was being left behind using os.rename. By switching to shutil we can move the file and delete the old cache data so temp files are properly cleaned up.