chore(api): DO NOT MERGE - show custom code in SDK reviews - #3649
Closed
apcha-oai wants to merge 1 commit into
Closed
chore(api): DO NOT MERGE - show custom code in SDK reviews#3649apcha-oai wants to merge 1 commit into
apcha-oai wants to merge 1 commit into
Conversation
Contributor
Castiron custom code✅ No new custom-code files detected. 49 mixed files remain; 0 existing customizations changed. Compared Legacy baseline: content hash computed from the pinned checkpoint; not yet recorded in that revision’s stats. 49 existing customizations unchanged
9 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 32174790388 --repo openai/openai-python \
--name castiron-custom-code-32174790388-1 --dir /tmp/castiron-custom-code-32174790388-1
git apply --stat /tmp/castiron-custom-code-32174790388-1/custom-code.patch
cat /tmp/castiron-custom-code-32174790388-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 44c1560ad2f707d68e3f28d66aae602f7626e187 31fe6374352211c856f2f49cafb60f0ef846f2e2
python3 scripts/castiron/custom_code_report.py report \
--base 44c1560ad2f707d68e3f28d66aae602f7626e187 \
--head 31fe6374352211c856f2f49cafb60f0ef846f2e2 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-31fe63743522
cat /tmp/castiron-custom-code-31fe63743522/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| import struct | ||
| import subprocess | ||
| import tempfile | ||
| import unittest |
apcha-oai
changed the title
apcha-oai
force-pushed
the
castiron/promotions/pr-34
branch
from
August 18, 2026 18:54
8e3a784 to
c99bd28
Compare
Castiron-Internal-PR: openai/openai-python-internal#34 Castiron-Source-SHA: 9fbcafee1844a5bf2a661ec8e5c5c1dfecb9c003 Castiron-Public-Base-SHA: 44c1560
apcha-oai
force-pushed
the
castiron/promotions/pr-34
branch
from
August 18, 2026 19:06
c99bd28 to
31fe637
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make handwritten changes in generated SDK files easier to review. One PR comment shows newly customized files, existing customizations that changed, and commands to inspect the current custom-code diff. It updates in place as the PR changes.
The reporting files come from shared Castiron templates and use normal three-way merges, so repository-specific customizations remain possible. The workflow checks the generated baseline's content hash. Public reporting uses only public snapshot history and needs no private-repository credentials.
This draft is limited to reporting and generation metadata; it does not change the SDK API or runtime. Workflow changes require the repository's normal workflow-write permissions.