-
Notifications
You must be signed in to change notification settings - Fork 5.1k
fix(types): make ResponseOutputText.text Optional to accept null from API #3632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -122,7 +122,7 @@ class ResponseOutputText(BaseModel): | |
| annotations: List[Annotation] | ||
| """The annotations of the text output.""" | ||
|
|
||
| text: str | ||
| text: Optional[str] = None | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
For Useful? React with 👍 / 👎. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
If a streaming response initializes an Useful? React with 👍 / 👎. |
||
| """The text output from the model.""" | ||
|
|
||
| type: Literal["output_text"] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the API returns the exact
text: nullpayload this change is intended to accept, deserialization now succeeds, but accessing the commonResponse.output_textconvenience property still appends thatNonevalue and passes it to"".join(...), raisingTypeError. Update the aggregator to skip or normalize null text in the same change so callers can safely consume these responses.Useful? React with 👍 / 👎.