fix(responses): guard parse_response against null response.output - #3629
Open
Xsidz wants to merge 1 commit into
Open
fix(responses): guard parse_response against null response.output#3629Xsidz wants to merge 1 commit into
Xsidz wants to merge 1 commit into
Conversation
Fixes openai#3312: when a response.completed event carries output=null (observed against chatgpt.com/backend-api/codex/responses and other OAI-compatible backends), parse_response iterated None and raised TypeError. Use `response.output or []` to short-circuit.
This was referenced Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3312 (and the related duplicates #3314, #3321, #3325, #3313).
parse_response()insrc/openai/lib/_parsing/_responses.pyiteratesresponse.outputunconditionally. Several backends (chatgpt.com Codex, OAI-compatible servers under load) emitresponse.completedwithoutput: null, which causes:One-character fix:
response.output or []short-circuits to an empty list when the field is null, returning aParsedResponsewith an empty output list rather than crashing.Test plan
tests/test_models.py,tests/test_transform.py,tests/lib/responses/: 121 passed, 0 failures.