fix(realtime): strip Omit/NotGiven in ConnectionManager.send pre-connect - #3627
Open
Xsidz wants to merge 1 commit into
Open
fix(realtime): strip Omit/NotGiven in ConnectionManager.send pre-connect#3627Xsidz wants to merge 1 commit into
Xsidz wants to merge 1 commit into
Conversation
Fixes openai#3402: the pre-connect manager send() paths called json.dumps() directly on dict events without running maybe_transform(), so passing omit or not_given values raised TypeError. Mirror the post-connect connection.send() behavior by wrapping with maybe_transform().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3402.
AsyncRealtimeConnectionManager.send()andRealtimeConnectionManager.send()calledjson.dumps(event)directly on dict payloads without first runningmaybe_transform(). The post-connectconnection.send()paths already wrap withmaybe_transform/async_maybe_transformto stripOmit/NotGivensentinels before serialization — the pre-connect manager paths were missing this step, causing:The fix adds
maybe_transform(event, RealtimeClientEventParam)to both managersend()paths, matching the existing post-connect behavior. Both managers have synchronoussend()signatures (queuing for later dispatch), somaybe_transform(not the async variant) is correct here.Test plan
tests/test_models.pyandtests/test_transform.py: 114 passed, 0 failures.maybe_transformwas already imported in the file — no import changes needed.