fix: remove dead error event code in _streaming.py#3455
Open
C1-BA-B1-F3 wants to merge 1 commit into
Open
Conversation
The error event handling inside the Assistants thread. event branch is unreachable because 'error' doesn't start with 'thread.'. The helper already handles this case correctly in the else branch.
nomiveritas
approved these changes
Jun 29, 2026
nomiveritas
left a comment
nomiveritas
left a comment
There was a problem hiding this comment.
LGTM. The removed sse.event == "error" check was unreachable because it was nested under sse.event.startswith("thread."). Error events are already handled in the non-thread branch, so this is a pure dead-code cleanup with no behavioral change.
Respectfully Nomiveritas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes unreachable error event handling code in both
Stream.__stream__andAsyncStream.__stream__.What was dead
Inside the Assistants
thread.event branch (if sse.event.startswith("thread.")), there was a check forsse.event == "error". Since"error"never starts with"thread.", this branch could never execute — it was dead code.The correct error handling for non-thread events already exists in the
elsebranch.Changes