fix(client): treat empty OPENAI_BASE_URL env var as unset#2976
Open
NIK-TIGER-BILL wants to merge 1 commit intoopenai:mainfrom
Open
fix(client): treat empty OPENAI_BASE_URL env var as unset#2976NIK-TIGER-BILL wants to merge 1 commit intoopenai:mainfrom
NIK-TIGER-BILL wants to merge 1 commit intoopenai:mainfrom
Conversation
When OPENAI_BASE_URL is defined but empty (e.g. OPENAI_BASE_URL=''),
os.environ.get('OPENAI_BASE_URL') returns an empty string, which is
truthy enough to skip the None check. The intended fallback to
'https://api.openai.com/v1' is never reached, causing an
APIConnectionError with a confusing empty base URL.
Fix: use 'os.environ.get("OPENAI_BASE_URL") or None' so that an
empty string is normalised to None and the default URL is applied.
Fixes openai#2927
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
OPENAI_BASE_URLis defined but empty (OPENAI_BASE_URL=""),os.environ.get("OPENAI_BASE_URL")returns an empty string. An empty string is falsy for== Nonebut not foris None, so the secondif base_url is Noneguard is never triggered and the intended fallback tohttps://api.openai.com/v1is skipped.The client then passes an empty string as
base_url, which results in a confusingAPIConnectionError: Connection error.Fix
Normalise an empty env var to
Noneso the default URL is applied.Same fix applied to both
OpenAIandAsyncOpenAIclient__init__methods.Fixes #2927