fix(client): guard against AttributeError in AsyncHttpxClientWrapper.…#2963
Open
raulblazquezbullon wants to merge 1 commit intoopenai:mainfrom
Open
fix(client): guard against AttributeError in AsyncHttpxClientWrapper.…#2963raulblazquezbullon wants to merge 1 commit intoopenai:mainfrom
raulblazquezbullon wants to merge 1 commit intoopenai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
Move the
is_closedguard inside thetry/exceptblock inAsyncHttpxClientWrapper.__del__.When
copy.deepcopy()is called on an object that holds anAsyncOpenAIinstance (e.g. viadataclasses.asdict()on a dataclass containing anOpenAIProviderfield), Python's deepcopy machinery creates a newAsyncHttpxClientWrappervia__new__(), leaving__dict__completely empty — and then fails while trying to copy the internal asyncio transport and locks. The partially constructed object is released, the GC collects it, and__del__crashes because_statewas never set.Observed traceback:
Concrete trigger (confirmed via debugger):
MLflow's agent tracer patches
Runner.run()and callsdataclasses.asdict(run_config)to set span attributes.asdict()callscopy.deepcopy()on non-dataclass fields, reachingOpenAIProvider->AsyncOpenAI->AsyncHttpxClientWrapper.deepcopycreates the wrapper via__new__()(empty__dict__), then raises an error copyingasynciointernals. The failed copy gets GC'd with no_state.The fix moves the check inside the existing
try/except Exception, consistent with the method's original intent to silence all finalization errors. No functional behaviour changes for fully initialized objects.Additional context & links
__dict__ = {}at__del__time, confirming init was never called, not that it failed partway through.dataclasses.asdictshould notdeepcopyobjects containingasynciointernals), but__del__should be robust regardless of how the object was constructed.