Skip to content

fix: allow SDK 0.25 in the external provider example - #6068

Merged
seratch merged 1 commit into
mainfrom
fix/provider-example-025
Nov 18, 2026
Merged

seratch merged 1 commit into
mainfrom
fix/provider-example-025

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

This pull request fixes the external provider example's dependency constraint so its documented local installation works with SDK 0.25.0. It widens the upper bound to <0.26.0, retains 0.24.x support, and updates the README to match. Provider behavior is unchanged.

Addresses the provider compatibility finding on the 0.25.0 release. This should land on main before Release Please refreshes that candidate.

Test plan

  • External-provider tests: 8 passed; specifier checks accept 0.24.0 and 0.25.0 and reject 0.26.0.
  • Independent focused review: no actionable findings.
  • Formatting, lint, mypy, and pyright passed.
  • Full verification reached tests: 12,578 passed, 26 skipped, 71 failed. Failures are in unchanged MCP redaction/sandbox tests: redaction assertions match user in the local checkout path /home/dev-user/...; sandbox snapshots fall back to no-op because the default state directory is read-only.
  • Rechecked the affected sandbox files plus the example with a writable XDG_STATE_HOME: 234 passed, 2 skipped.
  • Required GitHub CI must pass before merge. No real Docker demo was run.

Issue number

Release follow-up for release 0.25.0.

Checks

  • Existing focused tests cover the unchanged provider behavior; no new runtime behavior was added.
  • Ran .agents/skills/code-change-verification/scripts/run.sh.
  • All verification steps pass (local environment limitations above; await CI).
  • Completed independent code review before pushing.

@jbeckwith-oai
jbeckwith-oai requested review from a team, rm-openai and seratch as code owners November 18, 2026 00:09
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T00:09:54.189488Z 095651e PR opened
🔒 Security Review ✅ Completed 2026-11-18T00:10:30.020272Z 095651e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example dependency and README agree on the supported range for SDK 0.24 and 0.25. The prospective-release contract check has passed on this revision.

codex://threads/01a1c7cc-3ae0-7900-8710-5a1fbeb062d5

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Nov 18, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 18, 2026
@seratch
seratch added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 9b17858 Nov 18, 2026
28 checks passed
@seratch
seratch deleted the fix/provider-example-025 branch November 18, 2026 00:57
@openai-sdks openai-sdks Bot mentioned this pull request Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants