Skip to content

fix: sandbox memory selection across UTC offsets - #6066

Merged
seratch merged 1 commit into
mainfrom
fix/sandbox-memory-offset-ordering
Nov 18, 2026
Merged

seratch merged 1 commit into
mainfrom
fix/sandbox-memory-offset-ordering

Conversation

@seratch

@seratch seratch commented Nov 17, 2026

Copy link
Copy Markdown
Member

This pull request fixes sandbox memory consolidation selecting an older rollout when timestamps use different UTC offsets and the selection cap excludes one of them. Selection compares update times in UTC and preserves fractional-second precision, including for previously stored raw memories.

Fixes #6048

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T22:32:21.042035Z 64cc49f PR opened
🔒 Security Review ✅ Completed 2026-11-17T22:33:06.524390Z 64cc49f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed commit 64cc49f66cda65792543e15e47fc8c4a7eaa0141. Approved; no actionable findings.

UTC normalization fixes selection across offsets and day boundaries. Comparing the original fractional digits separately preserves sub-microsecond precision and treats trailing zeros consistently. Reviewed the timestamp producer and metadata extraction, existing stored memories, selection cap and rollout-ID tie-breaker, retained/removed selection, invalid/unknown fallback, and the regression cases. Persisted timestamp strings and selection schema remain unchanged. Independent static review reached the same conclusion.

Hosted checks at review: {'SUCCESS': 18, 'IN_PROGRESS': 6}. CI is still running. Static review only; no candidate code or local tests executed.

@seratch
seratch added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit e7ce15a Nov 18, 2026
26 checks passed
@seratch
seratch deleted the fix/sandbox-memory-offset-ordering branch November 18, 2026 00:57
@openai-sdks openai-sdks Bot mentioned this pull request Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sandbox memory consolidation selects older rollouts when updated_at timestamps use different UTC offsets

2 participants