Repository navigation
fix: sandbox memory selection across UTC offsets - #6066
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed commit 64cc49f66cda65792543e15e47fc8c4a7eaa0141. Approved; no actionable findings.
UTC normalization fixes selection across offsets and day boundaries. Comparing the original fractional digits separately preserves sub-microsecond precision and treats trailing zeros consistently. Reviewed the timestamp producer and metadata extraction, existing stored memories, selection cap and rollout-ID tie-breaker, retained/removed selection, invalid/unknown fallback, and the regression cases. Persisted timestamp strings and selection schema remain unchanged. Independent static review reached the same conclusion.
Hosted checks at review: {'SUCCESS': 18, 'IN_PROGRESS': 6}. CI is still running. Static review only; no candidate code or local tests executed.
This pull request fixes sandbox memory consolidation selecting an older rollout when timestamps use different UTC offsets and the selection cap excludes one of them. Selection compares update times in UTC and preserves fractional-second precision, including for previously stored raw memories.
Fixes #6048