Skip to content

fix: limit the Daytona extra to the supported 0.x SDK - #6065

Merged
seratch merged 1 commit into
mainfrom
fix/daytona-extra-version-range
Nov 17, 2026
Merged

seratch merged 1 commit into
mainfrom
fix/daytona-extra-version-range

Conversation

@seratch

@seratch seratch commented Nov 17, 2026

Copy link
Copy Markdown
Member

This pull request fixes dependency resolution for openai-agents[daytona]. Daytona 2.0 moved the sandbox creation types that DaytonaSandboxClient() imports, causing construction to fail even when the extra was installed. The extra now requires daytona>=0.226.1,<1. The lockfile still selects 0.226.1.

Fixes #6043

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T22:18:59.853621Z d0735a7 PR opened
🔒 Security Review ✅ Completed 2026-11-17T22:19:39.952722Z d0735a7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new bound keeps the extra on the 0.x API used by the sandbox adapter. The lockfile still selects 0.226.1. No blockers from static review.

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete two-file change and relevant Daytona adapter imports, dependency metadata, lockfile, and existing issue/feedback, with an independent static review. The upper bound preserves the supported 0.x integration and prevents incompatible major versions from being selected. The locked version remains 0.226.1. No actionable findings.

Hosted checks at review time: 2 skipped, 22 success, 2 in_progress. Static review only; no candidate code or local tests executed.

@seratch
seratch added this pull request to the merge queue Nov 17, 2026
Merged via the queue into main with commit fd78fa0 Nov 17, 2026
28 checks passed
@seratch
seratch deleted the fix/daytona-extra-version-range branch November 17, 2026 22:39
@openai-sdks openai-sdks Bot mentioned this pull request Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Daytona extra allows daytona 2.0, which removes the 0.x API DaytonaSandboxClient uses

3 participants