Repository navigation
Preserve native Python provider replay and retry behavior - #6004
Conversation
5998131 to
9613327
Compare
2bc7654 to
b3da261
Compare
8c199c7 to
8025e6d
Compare
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
6d9a6a8 to
abcd5a6
Compare
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed provider replay/reasoning/media conversion, response-start and usage accounting, per-attempt borrowed-client retry ownership, LiteLLM header scoping, trace spans, and isolated PyPy wheel qualification, with independent reviewers. No actionable findings. Static review only; no local code or tests executed. Hosted PyPy/native qualification remains pending. This review covers the current stacked diff against codex/parity-python-runtime-20261114.
abcd5a6 to
387dc61
Compare
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reconfirmed after retargeting to feat/codex-harness. The complete Git tree f090601623906e7f0566b5482fbe46ee9f4875c0 is identical to the comprehensively reviewed abcd5a6 tree. No new actionable findings. Static review only; no local code or tests executed. Hosted PyPy/native qualification remains pending.
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Re-reviewed 14b9f28 with an independent reviewer. The sole incremental change updates the API snapshot to match the already reviewed model declarations and reachable types; public signatures are unchanged. No actionable finding in this increment. Static review only; no candidate code or local tests executed. Hosted CI is pending. Native checkpoint-restore failures observed in the merged base PR #6003 remain under follow-up; this approval does not establish CI qualification.
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Re-reviewed the checkpoint retry fix at 878f4c9 with an independent reviewer. Ordinary staged retries now retain the original unfinished history while preserving the current native continuation, accepted application outputs, and remembered approvals. Source-session and turn ownership checks remain enforced; provider-managed occurrence-projected retries keep their existing path. No actionable findings in this increment. Static review only; no candidate code or local tests executed. Hosted CI remains pending; previously reported failures in the merged base remain separate follow-up items.
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Re-reviewed 00d9f7e with an independent reviewer. The sole incremental change makes the tracing test double accept the keyword-only model argument passed by the production callback and assert the expected None value. Ownership, cancellation, retirement, loop-affinity, and reply assertions remain intact. No actionable findings in this increment. Static review only; no candidate code or local tests executed. Hosted CI remains pending.
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Re-reviewed the sole change since 00d9f7e with an independent reviewer: the Docker qualification fixture now matches mounts by destination instead of assuming Docker inspection order. The hosted failure at the previous commit returned writable before readonly. The new uniqueness and exact-destination-set assertions reject duplicate, missing, and unexpected mounts while preserving bind type, source, and read/write checks. Cold-restore authority rejection, denied writes, persistence, and cleanup assertions remain intact. No new actionable findings.
Static review only; no candidate code or local tests executed. Current-head hosted checks are still pending; this approval does not claim Docker/native qualification has passed.
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Re-reviewed the sole change since 7a4686c with an independent reviewer. The Docker qualification fixture now expects the precise ValueError and executor-policy mismatch message raised by the restore guard. This addresses the remaining 1-failure/7-pass hosted Docker result at the preceding commit. The changed-permissions restore remains rejected; subsequent request-count, filesystem-isolation and container-cleanup assertions are preserved. Three created containers remains correct because the failed restore acquires its environment before policy validation and releases it on the opening-error path. No new actionable findings.
Static source and hosted-log review only; no candidate code or local tests executed. Current-head hosted checks are pending, so this approval does not claim Docker/native qualification has passed.
|
Hosted CI follow-up at
The source approval for the exception correction stands. This is a newly exposed qualification dependency blocker, not an established production regression. Static source and hosted-log review only; no local tests run. |
|
Additional hosted qualification follow-up at One concrete Windows fixture blocker is Static source and hosted-log review only; no candidate code or local tests executed. Current qualification remains incomplete; the source approval for the exception-only correction is unchanged. |
Summary
This PR preserves provider reasoning, tool media, and usage across native Python retries and resumes. It keeps retries within the authority of the existing provider client. It also keeps the unfinished checkpoint history when an ordinary staged retry follows a rejected input, while retaining the native continuation and accepted tool receipts.
The PyPy job builds a Linux x64 wheel, installs it in a clean environment, and exercises the installed SDK.
Test plan
Checks
AGENTS.md.