Skip to content

fix: pin mypy target platform to linux in pyproject.toml #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thegoodengineer wants to merge 1 commit into from
+1 −0
Closed

fix: pin mypy target platform to linux in pyproject.toml #4503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ convention = "google"
"tests/**/*.py" = ["ASYNC", "RUF006", "RUF012", "RUF100"]

[tool.mypy]
platform = "linux"

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve a Windows-targeted mypy pass

On native Windows, this makes make typecheck analyze every sys.platform branch as Linux instead of validating the supported Windows paths. Mypy's --help describes --platform as “Type check special-cased code for the given OS platform”; overriding it therefore hides the three Windows-only errors this change is intended to address, including the DockerSandboxClient temporary-file flow that the README explicitly recommends on Windows. Fix those errors or add a separate win32 mypy pass rather than making Windows contributors receive a passing result without checking Windows-specific code.

Useful? React with 👍 / 👎.

strict = true
disallow_incomplete_defs = false
disallow_untyped_defs = false
Expand Down
Loading